Re: [PATCH] fix disk->id abuse

[Marco Gerards]

[...]

>> We could write a macro for ID comparison that would compare both the
>> "driver ID" (disk->dev->id) and "device ID" (disk->id).  In this case,
>> we can omit disk->id initialization in the drivers supporting only one
>> device (e.g. memdisk) and only leave it where it's indeed needed for
>> identifying separate devices, thus removing potentially confusing code.
>
> Sounds fine, although what worries me most if the current usage of 'id' in
> scsi.c, which can lead to collision already.
>
> I assume using LUNs is a proper solution for that one?

No, it is not.  I think I already said so on IRC?

--
Marco