grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC] DISTLIST and gendistlist.sh


From: Felix Zielcke
Subject: Re: [RFC] DISTLIST and gendistlist.sh
Date: Tue, 02 Sep 2008 13:12:08 +0200

Am Samstag, den 30.08.2008, 22:11 -0400 schrieb Pavel Roskin:

> 
> svn ls -R | sed '/\/$/d' | sort > DISTLIST2

Thanks for the regexp.
The sort is actual not needed, `svn' does this and it places even the
files with a capital letter above everything else just like
gendistlist.sh.

> > This seems to be the best then nobody needs to remember to
> > update ./gendistlist.sh and current DISTLIST seems again already a bit
> > out of date ;)

> Thus, we don't need any lists for included or excluded files.  Things
> will change if we stop keeping dependent files in Subversion.

This was just a little hint from me that some files were recently again
added to SVN without adding them to DISTLIST by e.g. calling
gendistlist.sh
But that's the point why I do this whole thing now :)

Attached is now a patch which adds ./gendistlist.sh call to autogen.sh
and uses SVN in case it is avaible to generate it.

I think this now needs the decision of Marco and Okuji because the
DISTLIST file is actual used by them i.e. `make dist'

I think using `svn ls' is really great.
But 2 questions come now in my mind:

`make dist' already creates DISTLIST if it does not exist, so
should ./autogen.sh generate it or directly `make dist'

should autogen.sh/`make dist' use directly SVN or should it be in
gendistlist.sh?

Especially should ony SVN be used to generate it or should `make dist'
be actual supported for everyone?

For me it seems that DISTLIST thing is actually only useful for Okuji
and Marco or whoever in the future will maintain GRUB 2

-- 
Felix Zielcke

Attachment: distlist.diff.2
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]