Re: [PATCH] GSoC #09 Bitmap scaling

[Vesa Jääskeläinen]

Vesa Jääskeläinen wrote:
> Colin D Bennett wrote:
>> This patch adds image scaling support.  Nearest neighbor and bilinear
>> interpolation algorithms are supported.
>>
>> The gfxterm background_image command scales the background image to fit
>> the screen.  This can be controlled with the new --mode/-m option.
> 
> Copyrights years for new files seems wrong
> 
> It is really necessary that all generic graphical menu code like bitmap
> scaler works always. Not just for some optimized formats as otherwise it
> would render graphical menu unusable in some cases. It can be not so
> pretty on low end systems, but it should at least work. That is the
> reason there is map/unmap functions in video api.
> 
> So there has to be first generic implementation and then you can use
> optimized one if there exist one.
> 
> Basically I have not bothered to go formats below 1 byte. But obviously
> as there is now 1 bit format that needs to be supported too.
> 
> Perhaps there should be set/getpixel for bitmap or so. I do not want
> those to appear in video drivers thou at least as external.

Oh one extra thing. I would like that only create_scaled is visible out
side as accessible function. So this would only provide one easy entry
point for such functionality.

I am just wondering do we have module globals that are not exported
outside...