grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] new static const char[] modname


From: Felix Zielcke
Subject: Re: [PATCH] new static const char[] modname
Date: Sat, 30 Aug 2008 14:36:32 +0200

Am Samstag, den 30.08.2008, 14:01 +0200 schrieb Robert Millan:

> I think the idea with this was to unify the strings for grub_dprintf calls;
> your patch goes a bit further and also puts other sort of strings to share
> the same variable.
> 
> I think that's a bit dangerous, since changes intended for one use of the
> variable could collaterally affect the rest in subtle ways.  And it's not
> that useful in code size anyway.

Oh right, but then modname seems to be a bit the wrong name,
if it should ony be used for grub_dprintf.
For example the i386-pc biosdisc.c uses grub_dprintf("disk") and
partmap/pc.c uses "partition"

What about moddebugname or something like that then?

-- 
Felix Zielcke





reply via email to

[Prev in Thread] Current Thread [Next in Thread]