Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the name

[Robert Millan]

On Thu, Aug 14, 2008 at 07:34:05PM +0200, Felix Zielcke wrote:
> 2008-08-14  Felix Zielcke  <address@hidden>
> 
>         * util/getroot.c: Include <config.h>.
>         (grub_util_get_grub_dev): Rewritten.

Please explain the actual changes (or what they're for).

>    switch (grub_util_get_dev_abstraction (os_dev))
>      {
> -    case GRUB_DEV_ABSTRACTION_LVM:
> -      grub_dev = xmalloc (strlen (os_dev) - 12 + 1);
> +      case GRUB_DEV_ABSTRACTION_LVM:

Try to ommit big indentation changes from the patch.  If you change something
that requires a big chunk of code to be reindented, I think it's better if you
leave that out for readability (and mention so if you like).

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."