grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes


From: Robert Millan
Subject: Re: [PATCH] kern/err.c + disk/raid.c error handling fixes
Date: Wed, 13 Aug 2008 23:50:23 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Wed, Aug 13, 2008 at 10:31:36PM +0200, Felix Zielcke wrote:
> 
> Yes this change is no problem, grub-probe now compiles fine
> But grub-mkimage not:
> 
> grub_mkimage-util_misc.o: In function `grub_print_error':
> /home/fz/grub/grub2.svn/util/misc.c:315: undefined reference to 
> `grub_error_pop'
> /home/fz/grub/grub2.svn/util/misc.c:312: undefined reference to `grub_errno'
> /home/fz/grub/grub2.svn/util/misc.c:313: undefined reference to `grub_errmsg'
> /home/fz/grub/grub2.svn/util/misc.c:315: undefined reference to 
> `grub_error_pop'
> collect2: ld returned 1 exit status
> make: *** [grub-mkimage] Error 1

This is because util/misc.c adds error handling to grub-mkimage, which
wasn't there before.

If we can't do this in kern/err.c (although I really think it'd be simpler),
adding a new util/err.c that can be used by grub-probe but not grub-mkimage
would solve this.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]