Re: [PATCH] just skip over invalid/unsupported RAID

[Robert Millan]

On Mon, Aug 11, 2008 at 06:50:18PM +0200, Felix Zielcke wrote:
> Am Montag, den 11.08.2008, 16:28 +0200 schrieb Robert Millan:
> > GRUB_MOD_INIT(raid) could handle them just fine, with something like:
> > 
> >   grub_print_error ();
> >   grub_errno = GRUB_ERR_NONE;
> > 
> > if an error was found.
> > 
> 
> Thanks for your hint, this is now something I thought initially with the
> invalid BSD partitions.
> Showing an error but not aborting the whole thing.

IIRC, the difference is that with the invalid BSD partitions, rising errors
is ineffective as there can't be anyone to handle them (since we're inside
an iteration).

> I don't care much about the changelog, if you e.g. don't like the 2nd
> sentence then just remove it please on commit.
> 
> 
> 2008-08-11  Felix Zielcke  <address@hidden>
> 
>         * disk/raid.c (GRUB_MOD_INIT): Use grub_print_error() to show RAID 
>         errors and reset grub_errno. Do not give errors to the underlying 
> layer.

That'd be the upper layer.  E.g.

   (normal mode)
        |
        V
(GRUB_MOD_INIT(raid))
        |
        V
(grub_raid_scan_device)


> +  grub_print_error();

Missing space here (before the parenthesis).

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."