grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] skip over invalid BSD partitions


From: Felix Zielcke
Subject: Re: [PATCH] skip over invalid BSD partitions
Date: Tue, 05 Aug 2008 15:15:31 +0200

Am Dienstag, den 05.08.2008, 15:10 +0200 schrieb Marco Gerards:
> Felix Zielcke <address@hidden> writes:
> 
> > 2008-08-05  Felix Zielcke  <address@hidden>
> >
> >     * partmap/pc.c (pc_partition_map_iterate): Do not abort on an invalid 
> > BSD
> >     magic or if there's no space left, use grub_dprintf to issue a warning.
> 
> Looks fine.
Hurray.
> 
> > +               {
> > +                 grub_dprintf ("partition",
> > +                               "invalid disk label magic 0x%x on partition 
> > %d\n"
> > +                               label.magic, p.index);
> > +                 continue;
> > +               }
> 
> Isn't a comma missing after the second string?  I am surprised that
> this compiles.  Or am I missing something?
> 

Bah, I noticed the 2 missing spaces and then missed that one out :(
Attached.

Attachment: skip_invalid_bsd_parts.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]