grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] skip over invalid BSD partitions


From: Marco Gerards
Subject: Re: [PATCH] skip over invalid BSD partitions
Date: Tue, 05 Aug 2008 15:10:15 +0200
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

Felix Zielcke <address@hidden> writes:

> 2008-08-05  Felix Zielcke  <address@hidden>
>
>       * partmap/pc.c (pc_partition_map_iterate): Do not abort on an invalid 
> BSD
>       magic or if there's no space left, use grub_dprintf to issue a warning.

Looks fine.

> +                 {
> +                   grub_dprintf ("partition",
> +                                 "invalid disk label magic 0x%x on partition 
> %d\n"
> +                                 label.magic, p.index);
> +                   continue;
> +                 }

Isn't a comma missing after the second string?  I am surprised that
this compiles.  Or am I missing something?

--
Marco





reply via email to

[Prev in Thread] Current Thread [Next in Thread]