Re: [PATCH] update-grub for Cygwin

[Robert Millan]

On Mon, Aug 04, 2008 at 10:40:02PM +0200, Christian Franke wrote:
> Robert Millan wrote:
> >On Mon, Aug 04, 2008 at 09:46:03PM +0200, Christian Franke wrote:
> >  
> >>Here a more generic version which allows to specifiy windows system dirs 
> >>by /etc/default/grub:GRUB_WINDOWS_DIRS.
> >>
> >>Defaults to current SYSTEMDRIVE on Cygwin, and nothing on other OS.
> >>
> >>Christian
> >>
> >>2008-08-04  Christian Franke  <address@hidden>
> >>
> >>    * conf/common.rmk: Add `10_windows' to `update-grub_SCRIPTS'.
> >>    * util/grub.d/10_windows.in: New file.
> >>    * util/update-grub.in: Add export of GRUB_WINDOWS_DIRS.
> >>    
> >
> >Why is this needed?  Can't we do something like 'grub-probe -t device 
> >c:/ntldr'
> >or so?
> >
> >  
> 
> It is not needed for standard installations with ntldr on SYSTEMDRIVE (C:).
> The ability to specify GRUB_WINDOWS_DIRS is added to support 
> non-standard installations.
> It also allows to use 10_windows on other OS if os-prober is not available.

Why not have the user write a custom entry then?  I think it clutters the
user interface to add options for everything.  If a corner case (boot a non
native disk, can't use os-prober) can be supported by creating a new config
file, why not do that?  It was the whole reason for designing update-grub to
be easily extensible.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."