Re: [PATCH] PXE support for grub2

[Robert Millan]

On Sat, Aug 02, 2008 at 07:20:31PM +0800, Bean wrote:
> >> --- a/kern/i386/pc/startup.S
> >> +++ b/kern/i386/pc/startup.S
> >> @@ -2053,3 +2053,102 @@ FUNCTION(grub_vbe_bios_set_palette_data)
> >>       popl    %ebx
> >>       popl    %ebp
> >>       ret
> >> +
> >> +
> >> +pxe_rm_entry:
> >> +     .long   0
> >> +
> >> +/*
> >> + * struct grub_pxenv *grub_pxe_scan (void);
> >> + */
> >> +FUNCTION(grub_pxe_scan)
> >
> > Could these go in a module?  If they're only used by disk/i386/pc/pxe.c,
> > maybe they could be merged with that?
> 
> The problem is that they need to call real mode function provided by
> the pxe rom, so this code must be loaded under 1m. We can solve this
> with real mode stub or the patch suggested by daChaac, but it's not
> there yet. So we need to keep it in startup.S for some time.

Well I guess we can live with that for a while...

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."