grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Remove conf/*.mk from svn


From: Christian Franke
Subject: Re: Remove conf/*.mk from svn
Date: Mon, 28 Jul 2008 00:28:44 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071128 SeaMonkey/1.1.7

Pavel Roskin wrote:
On Fri, 2008-07-25 at 20:41 +0200, Christian Franke wrote:

I agree, the files generated by ./autogen.sh should be included in tarball, but not in the repo.
Additional prerequisites (autoconf, ruby) for builds from svn are IMO OK.

I agree.

At least we should put a message into *.mk files that would make it
clear that they are generated.


Yes.

For a release tarball, It IMO also makes sense to include util/parser.tab.c. It is platform-independent and rarely changed. This would remove bison from the list of prerequisites.


BTW: autogen.sh should "touch stamp-h.in" to be consistent with the Makefile rule for config.h.in.

What difference would it make?



$ patch < patch_changing_configure.ac_or_aclocal.m4

$ ./autogen.sh # runs autoheader etc.

$ ./configure

$ make # re-runs autoheader because stamp-h.in was not updated

Christian





reply via email to

[Prev in Thread] Current Thread [Next in Thread]