grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] update-grub for Cygwin


From: Robert Millan
Subject: Re: [PATCH] update-grub for Cygwin
Date: Sun, 27 Jul 2008 14:39:46 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Sun, Jul 27, 2008 at 02:09:02AM -0400, Pavel Roskin wrote:
> On Sat, 2008-07-26 at 14:53 +0200, Christian Franke wrote:
> > Robert Millan wrote:
> > > On Thu, Jul 24, 2008 at 10:19:17PM +0200, Christian Franke wrote:
> > >   
> > >> +  case "`uname 2>/dev/null`" in
> > >> +    CYGWIN*)
> > >>     
> > >
> > > Could this be done at build time instead? (when generating update-grub
> > > from update-grub.in)
> > >
> > >   
> > 
> > Yes, of course. Some alternatives:
> ...
> 
> I think it's better to have the check at the run time than any of those
> alternatives.  If we have many OS specific checks, then we can think how
> to leave the relevant ones.  At this point, it's probably not worth the
> trouble.

Ok I don't mind.  It was just a suggestion.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]