[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hold shift or control to disable timeout even timeout=0
|
From: |
Pavel Roskin |
|
Subject: |
Re: [PATCH] hold shift or control to disable timeout even timeout=0 |
|
Date: |
Wed, 23 Jul 2008 21:45:22 -0400 |
On Wed, 2008-07-23 at 20:36 -0500, David Fries wrote:
> I could make the argument that it is ten assmebly instructions, but I
> think the stronger case is the other two keyboard reading routines are
> right there in the same file.
>
> I suppose the grub_checkkey and the new grub_getshiftflags could both
> be moved out of core.img, but where would they go and how would they
> get assigned to the grub_term structure?
I think they should be in normal.mod, and should be assigned in the
normal.mod initialization. Maybe it could be a new file with
architecture specific code needed for normal.mod support.
--
Regards,
Pavel Roskin