Re: [PATCH] Enable writing to ATA devices, fix several bugs

[Marco Gerards]

Pavel Roskin <address@hidden> writes:

> Quoting Marco Gerards <address@hidden>:
>
>>> I cannot get the ata module to recognize the hard drive on my test
>>> machine, so more work is needed to test it on the real hardware.
>>
>> Right, this needs more work.  I will have another look at ATA soon :-)
>
> That would be great!
>
>>> If you check Linux include/linux/ata.h, 1 is ATA_ERR, and we really need
>>> ata_ok(), which checks multiple flags.  So it's clearly material for a
>>> separate patch.
>>
>> No, I cannot check the Linux code.  AFAIK this can cause copyright
>> problems.  But I agree that more and better error checking is
>> required.
>
> I know.  That's why I'll write it from specifications or maybe I'll
> take it from the GNU/Hurd code.

Taking it from Specifications will be better.

I think the ATA driver of GNU Mach comes from Linux 2.0 or so.  So
that won't change anything for us ;(.

--
Marco