Re: [PATCH] pc & gpt partmap iterators don't abort when their hook requests it

[Robert Millan]

On Thu, Jul 03, 2008 at 08:31:05PM +0200, Marco Gerards wrote:
> Robert Millan <address@hidden> writes:
> 
> > On Tue, Jul 01, 2008 at 03:25:32PM +0200, Robert Millan wrote:
> >> 
> >> See ChangeLog for description.  I'd really like to receive some review on
> >> this one, since the code it touches is so fragile (although I tested it on 
> >> a
> >> typical setup and it works).
> >
> > Tough luck.  Inmediately after this I noticed it breaks grub-setup (I 
> > tested it
> > by loading core.img directly).
> >
> > I found a few other callers that relied on the buggy behaviour.  Here's a 
> > new
> > patch.
> 
> Thanks for fixing this.  I had a quick look and it looks sane at first
> sight.

I just committed it (after fixing a pair of mistakes with grub_errno handling).

> Did you have a look at the other modules as well?

Yes.  At first glance, they don't appear to be affected.  However, since I
can't debug them, I wouldn't want to mess with them anyway.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)