Re: [PATCH] add a counter in grub_dprintf

[Robert Millan]

On Thu, Jun 26, 2008 at 05:20:51PM +0200, Javier Martín wrote:
> El jue, 26-06-2008 a las 16:08 +0200, Robert Millan escribió:
> > On Sat, Jun 21, 2008 at 04:35:07PM +0200, Javier Martín wrote:
> > > 
> > > Why not modify the build system to create _two_ instances of kernel.img,
> > > one with and another without debugging? grub_mkimage would create the
> > > normal, smaller core.img (without dprintf) for installing and embedding;
> > > and store a core_dbg.img in the /boot/grub folder,
> > 
> > This breaks the design and forces grub-mkimage to have:
> > 
> >   a) knowledge about GRUB paths
> > 
> >   b) requirement for root perms
> > 
> > instead of just being an utility to generate images.  I don't think it's
> > a good idea.
> > 
> Whoops, sorry, I meant that grub_mkimage would create two core.img
> images, one per kernel.img version, and then grub_install would copy
> them as usual. Then grub_setup would embed/set up the normal core.img
> or the debug version based on a switch. What I propose is basically
> modifying grub_mkimage to allow choosing the kernel.img file used and
> then adding some lines to grub_install so that the two versions of
> core.img are generated (but only the selected is embedded).

Ah;  then it sounds fine, I guess.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)