Re: Some concern about the journal support

[Bean]

On Fri, Jun 13, 2008 at 6:01 PM, Bean <address@hidden> wrote:
> On Fri, Jun 13, 2008 at 5:05 PM, Bean <address@hidden> wrote:
>> Hi,
>>
>> I think we need to disable journal sometimes. Tools like grub-setup
>> and grub-install is run in an active system, that means sectors could
>> easily end up in the journal. However, journal is a temperately
>> buffer, space can be reused after a while. In this case, we should
>> bypass the journal and access the underlying file system directly.
>> Perhaps we can use a variable like no_journal to control the journal
>> support, any suggestions ?
>
> More thoughts about this issue. I think the problem is in the
> read_hook. If we're just reading, it make no difference whether it's
> from journal or real location, however, if the read_hook is not empty,
> we also need to pass the sector location to upper layer. Perhaps we
> can disable journal when the read hook is not null ?

Hi,

This patch should fix the above problem.

-- 
Bean

e1.diff
Description: Text Data