Re: Bug#478238: grub-probe: fails to find drive for /dev/sda10

[Robert Millan]

On Mon, May 12, 2008 at 07:02:46PM +0300, Török Edwin wrote:
> Robert Millan wrote:
> > On Sun, May 11, 2008 at 02:35:41PM +0300, Török Edwin wrote:
> >   
> >> /dev/sda9 is not a valid OpenBSD partition, and in partmap/pc.c:176 the
> >> iteration fails with an error: invalid disk label magic 0x%x.
> >> If I replace that return with a continue, it works.
> >>
> >> The problem is that grub2 stops looking for more partitions as soon as
> >> it encountered the invalid partition,
> >>     
> >
> > I think a correct fix for this belongs in grub_partition_iterate().  It 
> > should
> > only let its hook determine abortability rather than mandate that invalid
> > partitions should cause abortion.  Please, can you test the attached patch?
> >   
> 
> I tested the patch, however it still says:
> grub-probe: error: Cannot find a GRUB drive for /dev/sda10.  Check your
> device.map.
> 
> I notice that /dev/sda10 appears in the -vv output though:
> home/egrub-probe: info: opening the device `/dev/sda9'
> grub-probe: info: opening the device `/dev/sda9'
> grub-probe: info: /dev/sda10 starts from 83987883
> grub-probe: info: opening the device hd0
> 
> I attached the full output of grub-probe -d /dev/sda10 -vv, for the case
> when /dev/sda9 has the wrong partition type.

It's better is you use grub-emu for this test.  It's less complex.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)