Re: [PATCH] Remote GDB debugging stub (for i386)

[Robert Millan]

On Thu, May 01, 2008 at 03:12:25PM +0200, Lubomir Rintel wrote:
> --- grub2/gdb/cstub.c 1970-01-01 01:00:00.000000000 +0100
> +++ grub2-gdb/gdb/cstub.c     2008-05-01 10:57:57.000000000 +0200
> @@ -0,0 +1,362 @@
> +/* cstub.c - machine independent portion of remote GDB stub */
> +/*
> + *  Copyright (C) 2006  Lubomir Kundrak

Please put the FSF in copyright notice (since copyright is being assigned).

Also acknowledge whatever copyright/license notice there was in code copied
from gdb (though if it was public domain, I think you can skip the latter).

> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License as published by
> + *  the Free Software Foundation; either version 2 of the License, or
> + *  (at your option) any later version.
> + *
> + *  This program is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *  GNU General Public License for more details.
> + *
> + *  You should have received a copy of the GNU General Public License
> + *  along with this program; if not, write to the Free Software
> + *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.

Please update to GPL 3.  I suggest you copy the whole blob since there are
improvements in the last paragraph.

>  /* The size of the first region which won't be compressed.  */
> -#define GRUB_KERNEL_MACHINE_RAW_SIZE         0x4A0
> +#define GRUB_KERNEL_MACHINE_RAW_SIZE         0x4BC

What caused this?   Any way we can have this dynamically calculated?
 
-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)