Re: [PATCH] Fix file name transformations (mostly)

[Robert Millan]

On Tue, Apr 15, 2008 at 12:12:28AM +0200, Lubomir Kundrak wrote:
> diff -urp grub-1.96.orig/util/update-grub.in grub-1.96/util/update-grub.in
> --- grub-1.96.orig/util/update-grub.in        2008-03-16 17:52:32.000000000 
> +0100
> +++ grub-1.96/util/update-grub.in     2008-03-16 17:59:42.000000000 +0100
> @@ -23,7 +23,7 @@ address@hidden@
>  address@hidden@
>  address@hidden@
>  address@hidden@
> -grub_prefix=`echo /boot/grub | sed ${transform}`
> +grub_prefix=/boot/`echo /grub | sed ${transform}`

Is the second slash intentional?

> --- grub-1.96.orig/util/update-grub_lib.in.transform  2008-03-23 
> 11:46:14.000000000 +0100
> +++ grub-1.96/util/update-grub_lib.in 2008-03-23 11:49:21.000000000 +0100
> @@ -95,7 +95,8 @@
>  {
>    # Prefer system path for space reasons (/boot/grub might be a very small
>    # partition in case of OpenFirmware, etc).
> -  for dir in ${pkgdatadir} /usr/share/grub /boot/grub ; do
> +  for dir in ${pkgdatadir} ${pkgdatadir}/`echo grub | sed ${transform}` \
> +             /boot/`echo grub | sed ${transform}`; do

I'd prefer is grub_prefix was defined here too (for readability).

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)