grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Native CD test results


From: Pavel Roskin
Subject: Re: Native CD test results
Date: Fri, 28 Mar 2008 13:40:09 -0400

On Thu, 2008-03-27 at 11:30 -0400, Pavel Roskin wrote:
> By the way, the fix for GRUB hanging when booting from a CD is not
> making any difference on the system where I discovered it initially.
> I
> need to look deeper.

Actually, it is making the difference, I must have used a wrong disk
when testing.  It's working fine.  So I've applied the patch.

And while "looking deeper", it turned out that there is a scary timebomb
in kern/i386/pc/startup.S.  Only the initial part of that file is
supposed to be uncompressed, but in fact, the error handlers of the
decompression function itself were spilling into the compressed area.
Adding even minimal debugging code would push the main part of
lzo1x_decompress() beyond the boundary defined by
GRUB_KERNEL_MACHINE_RAW_SIZE, which would crash even before "Welcome to
GRUB".

So I've applied another patch that assures that to uncompressed code
stays below GRUB_KERNEL_MACHINE_RAW_SIZE.  It would be nice to avoid any
constant here and make grub-mkimage.c use a label in the image, but it
would need more work and more testing.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]