grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [NEW PATCH] os-prober output parser


From: Robert Millan
Subject: Re: [NEW PATCH] os-prober output parser
Date: Thu, 20 Mar 2008 11:36:26 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Thu, Mar 20, 2008 at 11:02:35AM +0100, Fabian Greffrath wrote:
> Robert Millan schrieb:
> >which is very ugly if you ask me.  Okuji, do you have any comments on this?
> 
> Apart from this issue, is the script allright?

Also, you can remove this check now:

if [ -z "`grub-probe --help 2> /dev/null | grep '\-d,\ \-\-device'`" ] ; then
  # grub-probe does not support '--device' option yet (introduced in 
1.96+20080228)
  exit 0
fi

and please include a ChangeLog entry.  As far as I'm concerned, there's nothing
else missing.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]