Re: [PATCH] cdrom access patch

[Pavel Roskin]

On Mon, 2008-03-17 at 14:21 +0800, Bean wrote:

> >  At what point do we need to use the _name_ to calculate the BIOS number?
> >  Why cannot we simply store that number into some field?
> 
> If we use (cd0) as primary name, there are three places where the
> cdrom has to been checked.
> 
> 1. make_install_device in init.c.
> Here, given the boot drive number grub_boot_drive, we need to figure
> out the root device name. This is outside biosdisk, can't access
> device or disk.

OK, I see.  It looks like the names are closely tied to the BIOS
numbers.  Essentially, (fd0) is "(bios0)" and (hd0) is "(bios80)".  Yes,
we could extend that notation for "cd" devices, but it would complicate
the boot code that should be kept minimal.

I think it's OK to apply your patch, unless there are other objections.
Perhaps it's even better to apply the patch without the "cd" alias, so
that the aliases can be implemented separately in a more generic way.

-- 
Regards,
Pavel Roskin