Re: [PATCH] cdrom access patch

[Bean]

On Fri, Mar 14, 2008 at 6:59 AM, Christian Franke
<address@hidden> wrote:
> Bean wrote:
>  > On Wed, Mar 12, 2008 at 5:10 AM, Christian Franke
>
> > <...> wrote:
>  >
>  >> Bean wrote:
>  >>  > ...
>  >>
>  >>
>  >>  > After some testing, i think the new version has some compatible issue,
>  >>  > i remember Christian Franke reports that some bios doesn't support int
>  >>  > 42 for cdrom, so grub_biosdisk_check_int13_extensions will fail. Would
>  >>  > someone check if func 4b01 (the first patch cd.diff) works in such
>  >>  > situation ?
>  >>  >
>  >>  >
>  >>
>  >>  cd.diff works on this specific PC (Asus A8N, Phonix-Award BIOS), CD
>  >>  appears as hd31.
>  >>
>  >>  BTW: grub_biosdisk_iterate should IMO always expose the boot_drive (see
>  >>  my latest patch).
>  >>  With current CVS and cd.diff, the boot_drive would not be visible in
>  >>  'ls' if e.g 0x80=HDD, 0x82=boot CD (as seen on some old Laptop).
>  >>
>  >
>  > Thanks for the tip, please test the new patch, it start scanning for
>  > cdrom if the boot drive is larger than the last harddisk.
>  >
>  >
>
>  OK, also on this Laptop. CD appears as hd2 in 'ls'.
>
>  Patch is IMO good to go.

thanks a lot for your testing. if nobody objects, i would like to
commit it soon.

-- 
Bean