Re: [PATCH] Handling command line option for core.img and g2ldr

[Robert Millan]

On Fri, Feb 29, 2008 at 12:14:06AM +0800, Bean wrote:
> >
> >  There are worse situations in fact (in that they're more common), like RAID
> >  and LVM drives (which can be the boot device too).
> >
> >  But I don't think we need parser code for that.  The path part of the 
> > prefix
> >  (/boot/grub, but sometimes /grub) is already hardcoded in by grub-mkimage, 
> > so
> >  why not extend that to storing the whole path?  It's just a few bytes more
> >  (typically 4), which is much less than code to parse cmdline params.
> 
> I think this could work, it actually avoid a lot of trouble by storing
> the device name as well.

One thing I overlooked is that it wouldn't allow for 0xFF effect (i.e. get
the root drive from bios), which is also desirable (or even is that the
default?).

> A little setback is that we need to create
> different core.img for different boot device,

I don't think that's a big problem since core.img is generated every time in
grub-install (but in most cases, 0xFF setup will handle it, is that correct?).

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)