grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Generic halt and reboot commands (was: Re: grub2 efi patches)


From: Robert Millan
Subject: Re: Generic halt and reboot commands (was: Re: grub2 efi patches)
Date: Mon, 11 Feb 2008 15:11:44 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Sun, Feb 10, 2008 at 10:58:02PM +0100, Alexandre Boeglin wrote:
> Le dim 10 fév 2008 à 22:05:46 +0100, Robert Millan a écrit :
> > For consistency with similar code elsewhere in GRUB, I think it's better if
> > you made this:
> > 
> > #if defined(foo)
> > #elif defined(bar)
> > #endif
> 
> No whitespace before the opening bracket in this case ?

No.  See how other parts of GRUB do it.

> By the way, this case is a good example of when it's 10 times easier to
> produce a patch with SVN than with CVS ;)

I know...

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]