[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Generic halt and reboot commands (was: Re: grub2 efi patches)
|
From: |
Robert Millan |
|
Subject: |
Re: Generic halt and reboot commands (was: Re: grub2 efi patches) |
|
Date: |
Sun, 10 Feb 2008 22:05:46 +0100 |
|
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Sun, Feb 10, 2008 at 08:54:08PM +0100, Alexandre Boeglin wrote:
> +#ifdef GRUB_MACHINE_IEEE1275
> #include <grub/machine/kernel.h>
> +#elif defined GRUB_MACHINE_EFI
> +#include <grub/efi/efi.h>
> +#endif
For consistency with similar code elsewhere in GRUB, I think it's better if
you made this:
#if defined(foo)
#elif defined(bar)
#endif
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
- Re: grub2 efi patches, (continued)
Re: grub2 efi patches, Alexandre Boeglin, 2008/02/05
- Re: grub2 efi patches, Robert Millan, 2008/02/05
- Generic halt and reboot commands (was: Re: grub2 efi patches), Alexandre Boeglin, 2008/02/10
- Re: Generic halt and reboot commands (was: Re: grub2 efi patches), Robert Millan, 2008/02/10
- Re: Generic halt and reboot commands (was: Re: grub2 efi patches), Alexandre Boeglin, 2008/02/10
- Re: Generic halt and reboot commands (was: Re: grub2 efi patches),
Robert Millan <=
- Re: Generic halt and reboot commands (was: Re: grub2 efi patches), Alexandre Boeglin, 2008/02/10
- Re: Generic halt and reboot commands (was: Re: grub2 efi patches), Robert Millan, 2008/02/11
- Re: Generic halt and reboot commands (was: Re: grub2 efi patches), Alexandre Boeglin, 2008/02/11
- Re: Generic halt and reboot commands (was: Re: grub2 efi patches), Robert Millan, 2008/02/12
- Re: Generic halt and reboot commands (was: Re: grub2 efi patches), Alexandre Boeglin, 2008/02/12
- Re: Generic halt and reboot commands (was: Re: grub2 efi patches), Robert Millan, 2008/02/12