Re: [PATCH] if timeout is set to zero, don't bother drawing the menu

[Yoshinori K. Okuji]

On Sunday 10 February 2008 13:55, Robert Millan wrote:
> We could make the behaviour be, that if ESC is pressed at any time before
> an input line is completed, the operation is aborted, read returns
> non-zero, and it doesn't save the line to any variable.  What do you think?

Not bad. :)

> > In GRUB Legacy, the hidden menu uses ESC, because if it uses ENTER, and
> > the user pushes ENTER too long, and a key repeat occurs, then the first
> > item may be selected quick as a flash. But we could avoid this problem by
> > vacuuming all inputs before showing a menu, so it might be acceptable to
> > use ENTER instead.
>
> This is still error-prone.  Even if you vacuum the input buffer, we still
> have a race between user unholding ENTER and GRUB showing the menu. 
> Vacuuming the buffer just gives us more time, but doesn't garantee good
> results.

Sure, but I think it would be good enough in reality.

> > (Actually, this should be implemented, regardless of this issue, because
> > some BIOSes may leave garbage in a key buffer. I don't remember if this
> > has been done for GRUB 2.)
>
> You mean garbage is present when control is transfered to GRUB, or
> generated afterwards?  I assume the first, but then if any user input is
> attempted before removing the garbage, it may be corrupted.  So it should
> be done as early as possible, shouldn't it?  Perhaps in
> grub_console_init()?

Maybe. Personally, I don't mind even if it is done at the startup.

Okuji