Re: [PATCH] Create floppy emulation boot CD with grub-mkimage

[Robert Millan]

On Sat, Feb 09, 2008 at 07:56:16PM +0800, Bean wrote:
>        if (grub_root_drive == 0xFF)
>          grub_root_drive = grub_boot_drive;
> 
> -      if (grub_root_drive >= GRUB_BIOSDISK_MACHINE_CDROM_START)
> -        grub_sprintf (dev, "(cd%u",
> -                   grub_root_drive - GRUB_BIOSDISK_MACHINE_CDROM_START);
> +      if ((grub_root_drive >= GRUB_BIOSDISK_MACHINE_CDROM_START) &&
> +          (grub_root_drive < GRUB_BIOSDISK_MACHINE_CDROM_END))
> +     grub_strcpy (dev, "(cd0)");
>        else
>          grub_sprintf (dev, "(%cd%u",
>                     (grub_root_drive & 0x80) ? 'h' : 'f',

I'm confused by this.  Did you mean the opposite?  I.e. when grub_root_drive
is out of bounds, set dev to cd0.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)