Re: [PATCH] fix for partmap detection on RAID/LVM

[Robert Millan]

On Fri, Feb 08, 2008 at 09:38:25PM +0000, Sam Morris wrote:
> > diff -x configure -x config.h.in -x CVS -x '*~' -x '*.mk' -urp -N
> > ../grub2/disk/raid.c ./disk/raid.c --- ../grub2/disk/raid.c       
> > 2008-02-08 13:35:05.000000000 +0100 +++ ./disk/raid.c       2008-02-08
> > 20:36:47.000000000 +0100 @@ -419,7 +419,7 @@ grub_raid_scan_device
> > (const char *name)
> >           return 0;
> >         }
> > 
> > -      if (array->device[sb.this_disk.number]->name != 0) +      if
> > (array->device[sb.this_disk.number] != NULL)
> >         {
> >           /* We found multiple devices with the same number. Again,
> >              this shouldn't happen.*/
> > 
> > does this work?
> 
> Looks like it!

Great.  I have committed the segfault bugfix (but not the partmap patch
yet).

> $ sudo ./grub-probe -t partmap /boot/grub/
> pc
> pc

Now that I think about it... does this cause grub-install / grub-mkimage
to load pc.mod twice?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)