Re: [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio trailer detection

[Bean]

On Feb 6, 2008 7:02 AM, Christian Franke <address@hidden> wrote:
> Two issues found in current CVS:
>
> 1. Booting a grub2-mkrescue floppy crashes if
> "(memdisk)/boot/grub/grub.cfg" does not exist. This is because
> grub_cpio_open does not set grub_errno if a file does not exist.
>
> 2. The cpio format may not work. Header scan finishes early if data size
> is empty (directory, empty file). The cpio format uses the name
> "TRAILER!!!" to mark the last block.
>
> This patch fixes both issues.

Actually, the first version of grub_cpio_find_file returned
GRUB_ERR_FILE_NONE when the end of file is encounter, but then,
somebody find out that opening non existent file have problem, and the
result is changed  to GRUB_ERR_FILE_NOT_FOUND. I guess it still have
problem, the fix you are providing seems ok.

> Open issues not fixed in this patch:
>
> - Directory detection relies on a trailing '/' in path name. This works
> for typical tar files, but not for cpio. As a consequence, tab
> completion and "ls -l" are not correct. The "mode" in the header should
> be checked instead.
>
> - CPIO would not work on big endian architectures yet.
>

yes, i know this problem, i can fix it sometime.

-- 
Bean