Re: [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio trailer detection

[Robert Millan]

Hi Christian,

On Wed, Feb 06, 2008 at 12:02:37AM +0100, Christian Franke wrote:
> Two issues found in current CVS:
> 
> 1. Booting a grub2-mkrescue floppy crashes if 
> "(memdisk)/boot/grub/grub.cfg" does not exist. This is because 
> grub_cpio_open does not set grub_errno if a file does not exist.

I can't reproduce this with qemu:

  ./grub-mkrescue --pkglibdir=`pwd` --grub-mkimage=`pwd`/grub-mkimage 
--image-type=floppy /tmp/grub-rescue-floppy.img
  qemu -fda /tmp/grub-rescue-floppy.img -boot a

is this supposed to be a spurious problem?

> 2008-02-05  Christian Franke  <address@hidden>
> 
>       * fs/cpio.c (grub_cpio_find_file): Return GRUB_ERR_NONE
>       and (*ofs = 0) instead of GRUB_ERR_FILE_NOT_FOUND on last

I would suggest "(and set *ofs = 0)" here to make it clearer.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)