Re: [PATCH] to make grub2 compile on NetBSD

[Marco Gerards]

walt <address@hidden> writes:

> Robert Millan wrote:
>>>> walt<address@hidden>  writes:
>>>>
>>>>> NetBSD's gcc wants libgcc and libc to define __enable_execute_stack,
>>>>> but this is useless for a free-standing executable like grub.  Define
>>>>> a dummy function in lieu of libgcc to supply __enable_execute_stack.
>
>>> Second try:
>>>
>>>     Make NetBSD's gcc happy.
>>>
>>>     * kern/mm.c: New dummy symbol __enable_execute_stack.
>>>     (include/grub/mm.h): Likewise.
>>
>> This ChangeLog entry seems wrong.  I'll write it up for you, as it's easier 
>> to
>> explain with an example:
>>
>>      Make NetBSD's gcc happy.
>>
>>      * include/grub/mm.h
>>      [__NetBSD__] (__enable_execute_stack): New function prototype.
>>      * kern/mm.c
>>      [__NetBSD__] (__enable_execute_stack): New function.
>
> Okay, thanks.  Does the [__NetBSD__] token denote an #ifdef?  How
> would I indicate a patch for, say, Net/Free/Dragonfly BSD's at the
> same time?
>
> Oh, and should you mention that the new function does nothing?
>
> Marco:  I didn't add the header for the changelog because I don't
> know who (if anyone) is going to commit it.

Your name and email address should be used when committing, at least
that's preferred.  The date will be updated to the commit date when
committing.

--
Marco