Re: [PATCH] to make grub2 compile on NetBSD

[Marco Gerards]

walt <address@hidden> writes:

> On Mon, 2008-02-04 at 16:56 +0100, Marco Gerards wrote:
>> walt <address@hidden> writes:
>> 
>> > NetBSD's gcc wants libgcc and libc to define __enable_execute_stack,
>> > but this is useless for a free-standing executable like grub.  Define
>> > a dummy function in lieu of libgcc to supply __enable_execute_stack.
>
>> ...  If this is for NetBSD only,
>> shouldn't you add a #ifdef instead of a comment?
>
> Second try:
>
>       Make NetBSD's gcc happy.
>
>       * kern/mm.c: New dummy symbol __enable_execute_stack.
>       (include/grub/mm.h): Likewise.

The patch looks fine to me.  Can you please supply the header for the
changelog entry?  It's not complete this way.

--
Marco