grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: grub.cfg parser still doesn't abort on error


From: Robert Millan
Subject: Re: grub.cfg parser still doesn't abort on error
Date: Sun, 3 Feb 2008 19:26:51 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Sun, Feb 03, 2008 at 03:53:42PM +0100, Robert Millan wrote:
> On Sun, Feb 03, 2008 at 02:29:55PM +0100, Robert Millan wrote:
> > On Sun, Feb 03, 2008 at 09:05:38PM +0800, Bean wrote:
> > > 
> > > if font (xxx)/some-file.pff ; then
> > >   # graphic mode setting
> > > else
> > >   # text mode setting
> > > fi
> > > 
> > > i think this behavior is consistent with sh, an error code returned
> > > from command should not cause the script to abort.
> > 
> > Urg, part of update-grub was written with the idea that this ought to be
> > handled in "build" time.  I guess I'll have to overhaul some of it...
> 
> Well, it wasn't such a big change after all.  The sanity checks done at 
> grub.cfg
> generation time are worth keeping, IMHO, since they off-load GRUB from
> performing them (and it is more practical to add logic in bash when possible).
> 
> This should address the problem.

Committed.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]