grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] read command


From: Robert Millan
Subject: Re: [PATCH] read command
Date: Sat, 2 Feb 2008 21:34:03 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Sat, Feb 02, 2008 at 07:48:57PM +0100, Yoshinori K. Okuji wrote:
> > Ok, here's a new patch, with grub_getline returning NULL and the caller
> > handling "out of mem" error.
> >
> > Also fixed a memleak.
> 
> You don't have to set grub_errno explicitly, because grub_realloc should do 
> it.
> 
> And, you didn't check the return value from grub_malloc.

Fixed and committed.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]