Re: [PATCH] read command

[Yoshinori K. Okuji]

On Saturday 02 February 2008 18:05, Robert Millan wrote:
> On Sat, Feb 02, 2008 at 01:38:28PM +0100, Yoshinori K. Okuji wrote:
> > > Does it make sense to move any of these two to kernel?  Or to
> > > normal.mod ? Or maybe just to un-static-ize them and leave them here?
> >
> > What would be other use cases?
>
> No idea.  I suggest we just leave grub_getline here and if later we find
> it's needed we can move it to normal or kernel.

OK.

> Ok, here's a new patch, with grub_getline returning NULL and the caller
> handling "out of mem" error.
>
> Also fixed a memleak.

You don't have to set grub_errno explicitly, because grub_realloc should do 
it.

And, you didn't check the return value from grub_malloc.

Okuji