Re: [PATCH] eltorito cdrom boot

[Bean]

On Feb 3, 2008 12:33 AM, Robert Millan <address@hidden> wrote:
> On Sat, Feb 02, 2008 at 10:19:55PM +0800, Bean wrote:
> >
> > any objection for this patch ? i would like to commit it soon.
>
> Looks fine to me.  Just a minor comment:
>
> > +#define GRUB_BIOSDISK_MACHINE_CDROM_START 0xe0
> > +#define GRUB_BIOSDISK_MACHINE_CDROM_END 0xf0
>
> could you make this tab-indented?

no problem.

>
> Also, I notice that GRUB_BIOSDISK_MACHINE_CDROM_END is not used.  Did you plan
> to add a sanity check in init.c using this macro ?

it's used in GRUB_MOD_INIT(biosdisk) as the end drive letter to scan for cds.

-- 
Bean