Re: Compiling grub2 on *BSD?

[Robert Millan]

On Fri, Feb 01, 2008 at 01:11:06PM -0800, walt wrote:
> > ... if we remove -lgcc, what happens if it becomes necessary for other 
> > versions
> > of GCC?  Or does gcc already add libgcc per demand?
> 
> I got grub2 compiled on NetBSD using the fake in those pkgsrc patches.
> I regenerated the patches below against grub2 cvs.  They are the same
> ideas you suggested earlier, I just didn't use them all at the same
> time:

Nice.  Some comments:

> --- include/grub/mm.h   21 Jul 2007 23:32:22 -0000      1.8
> +++ include/grub/mm.h   1 Feb 2008 21:04:27 -0000
> @@ -33,6 +33,7 @@
>  void EXPORT_FUNC(grub_free) (void *ptr);
>  void *EXPORT_FUNC(grub_realloc) (void *ptr, grub_size_t size);
>  void *EXPORT_FUNC(grub_memalign) (grub_size_t align, grub_size_t size);
> +void EXPORT_FUNC(__enable_execute_stack) (void);
>  
>  /* For debugging.  */
>  #if defined(MM_DEBUG) && !defined(GRUB_UTIL)
> Index: kern/mm.c
> ===================================================================
> RCS file: /sources/grub/grub2/kern/mm.c,v
> retrieving revision 1.19
> diff -u -r1.19 mm.c
> --- kern/mm.c   23 Jan 2008 14:57:40 -0000      1.19
> +++ kern/mm.c   1 Feb 2008 21:04:28 -0000
> @@ -66,6 +66,9 @@
>  #include <grub/disk.h>
>  #include <grub/dl.h>
>  
> +void __enable_execute_stack(void);

Why this declaration; doesn't it duplicate the one in mm.h?

> +void __enable_execute_stack(void) {}

We need a comment explaining why we have this "weird" function in GRUB.
Also, please follow grub code style:

void
foo (void)
{
}

And, could you provide a ChangeLog entry with your patch?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)