Re: [PATCH] btree support in xfs driver

[Robert Millan]

On Fri, Feb 01, 2008 at 03:40:20AM +0800, Bean wrote:
> Hi,
> 
> I add btree support for the xfs driver, and fix a few bugs. Now i' m
> able to list a directory of over 5000 files, please test it.

You're truly impressive...

One comment:

>  {
>    struct grub_fshelp_node *diro = (struct grub_fshelp_node *) dir;
> -  auto int call_hook (grub_uint64_t ino, char *filename);
> +  auto int __attribute__ ((regparm(1))) call_hook (grub_uint64_t ino,
> char *filename);
> 
> -  int call_hook (grub_uint64_t ino, char *filename)
> +  int __attribute__ ((regparm(1))) call_hook (grub_uint64_t ino, char
> *filename)

would this break on non-i386 ?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)