Re: PCI support

[Robert Millan]

On Wed, Jan 30, 2008 at 09:08:34PM +0100, Marco Gerards wrote:
> Robert Millan <address@hidden> writes:
> 
> > On Wed, Jan 30, 2008 at 06:57:38PM +0100, Marco Gerards wrote:
> >> Marco Gerards <address@hidden> writes:
> >> 
> >> > 2009-01-28  Marco Gerards  <address@hidden>
> >> >
> >> >  * bus/pci.c: New file.
> >> >
> >> >  * include/grub/pci.h: Likewise.
> >> >
> >> >  * include/grub/i386/pc/pci.h: Likewise.
> >> >
> >> >  * commands/lspci.c: Likewise.
> >> >
> >> >  * conf/i386-pc.rmk (pkglib_MODULES): Add `pci.mod' and
> >> >  `lspci.mod'.
> >> >  (pci_mod_SOURCES): New variable.
> >> >  (pci_mod_CFLAGS): Likewise.
> >> >  (pci_mod_LDFLAGS): Likewise.
> >> >  (lspci_mod_SOURCES): Likewise.
> >> >  (lspci_mod_CFLAGS): Likewise.
> >> >  (lspci_mod_LDFLAGS): Likewise.  
> >> 
> >> No objections?  Did everyone have a (quick) look at the interfaces?
> >
> > You put grub_pci_read() in an arch-specific file;  is that function really
> > arch-specific, or only its IO addresses are?
> 
> IO addresses are Intel only, AFAIK.  Almost all architectures have
> mmapped IO.  It's really arch specific.

Are you sure that makes grub_inl / grub_outl arch-specific ?  They can't be
implemented as wrappers for direct memory access?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)