|
From: | Pavel Roskin |
Subject: | Re: [PATCH] Don't abort if prefix is not set |
Date: | Sat, 26 Jan 2008 15:31:34 -0500 |
User-agent: | Internet Messaging Program (IMP) H3 (4.1.4) |
Quoting Robert Millan <address@hidden>:
On Sat, Jan 26, 2008 at 03:11:02PM -0500, Pavel Roskin wrote:Quoting Robert Millan <address@hidden>: >>+ if (! grub_dl_dir) { >>+ grub_error (GRUB_ERR_FILE_NOT_FOUND, "\"prefix\" is not set"); >>+ return 0; > >Seems fine, but are you sure this error is handled somewhere? If prefix is not set, the module is not loaded. What other handling do we need?What I mean is, is the error message printed? I recall it had to be handled somewhere. Or maybe I'm confused...
It's printed. Tested with grub-emu and in qemu.
I found that prefix would not be set on PowerPC if /memory/available is missing.Sounds strange.. how is that so?
Because the environment is allocated in the heap, I believe.
Even though I have a better workaround for it now, I still think that aborting for such minor reason is wrong. After all, the user may unset prefix.Agreed..
Applying. -- Regards, Pavel Roskin
[Prev in Thread] | Current Thread | [Next in Thread] |