Re: UFS (FFS) support seems broken in grub2

[Marco Gerards]

Bean <address@hidden> writes:

> On Jan 24, 2008 12:15 AM, walt <address@hidden> wrote:
>> Bean wrote:
>> > This patch should fix the problem...
>>
>> Yes, thanks!  I had to use the -l flag before patch would use it,
>> and even then the last hunk needed increased fuzz.
>>
>> Are you going to commit it today?
>
> thanks for the testing, if you have ufs2, please check it as well.

Hopefully it can be tested.

> this is the new patch after adding changelog:
>
>
>       * fs/ufs.c (GRUB_UFS_MAX_VOLLEN) : New constant.

s/constant/macro/

VOLNAME_LEN would be better, I think

>       (grub_ufs_sblock) : New member volume name.
>       (grub_ufs_find_file) : Fix string copy bug.
>       (grub_ufs_label) : Implement this function properly.

If you can make these changes, feel free to commit the patch.

--
Marco