[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] use of grub_dprintf in grub_mm_init_region() is misleading
From: |
Marco Gerards |
Subject: |
Re: [PATCH] use of grub_dprintf in grub_mm_init_region() is misleading |
Date: |
Wed, 23 Jan 2008 14:53:58 +0100 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) |
Robert Millan <address@hidden> writes:
> Using grub_dprintf() in grub_mm_init_region() easily leads to think that one
> can activate this debug message by issuing `grub_env_set ("debug", "mem")' in
> grub_machine_init(), before memory initialisation.
>
> However, that's completely false. grub_env_set will silently [1] ignore your
> call because grub_malloc() ain't usable, possibly making you think for a while
> that no free memory was found, and that memory was not initialized at all!
>
> I propose turning it into a disabled grub_printf().
Fine for me.
--
Marco