Re: grub2 efi patches

[Robert Millan]

On Sun, Nov 18, 2007 at 07:14:03PM +0100, Alexandre Boeglin wrote:
> Index: commands/i386/efi/halt.c
> ===================================================================
> RCS file: commands/i386/efi/halt.c
> diff -N commands/i386/efi/halt.c

> [...]

> +static grub_err_t
> +grub_cmd_halt (struct grub_arg_list *state __attribute__ ((unused)),
> +            int argc __attribute__ ((unused)),
> +            char **args __attribute__ ((unused)))
> +
> +{
> +  grub_halt ();
> +  return 0;
> +}
> +
> +
> +
> +GRUB_MOD_INIT(halt)
> +{
> +  (void)mod;                 /* To stop warning. */
> +  grub_register_command ("halt", grub_cmd_halt, GRUB_COMMAND_FLAG_BOTH,
> +                      "halt", "Halt the computer", 0);
> +}
> +
> +GRUB_MOD_FINI(halt)
> +{
> +  grub_unregister_command ("halt");
> +}

commands/ieee1275/halt.c looks like the same thing to me.  Perhaps it'd make
more sense to move that to commands/halt.c and use it as the "generic" version
of halt command?

> Index: commands/i386/efi/reboot.c
> ===================================================================
> RCS file: commands/i386/efi/reboot.c
> diff -N commands/i386/efi/reboot.c
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ commands/i386/efi/reboot.c        18 Nov 2007 17:49:37 -0000

Possibly the same applies here.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)