Re: [PATCH] use at_keyboard.c on i386-ieee1275

[Marco Gerards]

Robert Millan <address@hidden> writes:

> On Wed, Jan 23, 2008 at 11:58:58AM +0100, Marco Gerards wrote:
>> Robert Millan <address@hidden> writes:
>> 
>> > Taking into account that ofconsole on i386:
>> >
>> >   - Has bugs with similar usability effect than at_keyboard.c (e.g. arrow 
>> > keys
>> >     not working).
>> >   - In practice doesn't provide support for any keyboard other than AT
>> >     (since OFW shuts down USB before transfering control to us).
>> >   - Sharing code with other ports (CoreBoot, attow) is more efficient to 
>> > get
>> >     these bugs solved.
>> >
>> > I propose to use at_keyboard.c as default for i386-ieee1275.
>> 
>> Fine for me, it is your baby :-) Although you forgot the changelog entry.
>
>         * conf/i386-ieee1275.rmk (kernel_elf_SOURCES): Add
>         `term/i386/pc/at_keyboard.c'.
>
>         * include/grub/i386/ieee1275/console.h: Add `<grub/symbol.h>'.  Remove
>         `<grub/powerpc/ieee1275/console.h>'.
>         (grub_keyboard_controller_init): New function prototype.
>         (grub_console_checkkey): Likewise.
>         (grub_console_getkey): Likewise.
>
>         * kern/powerpc/ieee1275/init.c (grub_machine_init): Initialize AT
>         keyboard on i386.
>
>         * term/ieee1275/ofconsole.c (grub_ofconsole_term): On i386, use
>         grub_ofconsole_checkkey() and grub_ofconsole_getkey() for input.

Looks fine to me.

>> Will you fix the ifdef's soon?
>
> My plan is to propose a split of terminal handling in kernel so that input and
> output terminals become different objects.  This would fix this hack and 
> others
> (such as intermangled at_keyboard.c/vga_text.c with console.c in CB port, or
> gfxterm depending on grub_console_{get,check}key() ).

Great!

> But I'd like to leave this for later.  As mentioned on IRC, Debian is planning
> to start stabilizing next release in March.  If GRUB 2 is mostly in shape at
> that time, we'll be able to use it as the default bootloader.

That's a good idea.

> Which reminds me, is 1.96 coming soon?  When lvm/raid, reiserfs and powerpc
> issues are fixed, it might be a good time.  What do you think?

Fine for me, we didn't have a release for quite a while.  To be
honest, I just hate the upload procedure of ftp://alpha.gnu.org.  The
documents can be interpreted in two ways, or my English simply sucks.
That's one reason for me not to release that quickly. ;-)

>> Doesn't this cause any problems?  Now there are two keyboard drivers
>> active.
>
> Not at all.  I didn't bother #ifdefing grub_ofconsole_{get,check}key out to
> avoid cluttering it (since space is not critical), but it works fine here.

Ok!

> The only drawback is that it doesn't automaticaly switch to serial tty when
> OFW is running there, but that's a problem for every other port anyway (I
> have a solution in mind as well;  when we redesign terminal handling, we
> could layout a scheme in which multiple input or output terminals can be
> active at the same time).

Yes, that would be nice! :-)

--
Marco