grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] allow user-configurable menucolor


From: Marco Gerards
Subject: Re: [PATCH] allow user-configurable menucolor
Date: Wed, 23 Jan 2008 09:56:41 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

Robert Millan <address@hidden> writes:

> On Thu, Jan 03, 2008 at 06:04:59PM +0200, Vesa Jääskeläinen wrote:
>> 
>> About error handling:
>> 
>> Why not call grub_error() with error message and just return from
>> callback, and let prompt handle error processing (grub_print_error()).
>> This would keep error reporting centralized.
>
> One thing I don't like about grub_error() is that I never know what value to
> pick for the first parameter.  I find this confusing :-/

You can add errors to the enum.

--
Marco





reply via email to

[Prev in Thread] Current Thread [Next in Thread]