grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] safety check in claim_heap()


From: Marco Gerards
Subject: Re: [PATCH] safety check in claim_heap()
Date: Mon, 21 Jan 2008 22:11:42 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

Robert Millan <address@hidden> writes:

> On Mon, Jan 21, 2008 at 07:07:37PM +0100, Marco Gerards wrote:
>> Robert Millan <address@hidden> writes:
>> 
>> Hi,
>> 
>> > What do you think of adding this kind of checks?  I know it's not a
>> > perfect safegard, but it can save your day in some situations (it helped
>> > me during i386/ieee1275 port, when link address was 0x100000).
>> 
>> If this fixes the i386-ieee1275 port, this is fine to me.
>
> It isn't currently needed by either of the i386-ieee1275 targets (qemu and
> xo).
>
> However, it was during an earlier stage of the port in which link address
> was 0x100000 rather than 0x10000.
>
> My question is whether it makes sense as a general safety check.

Well, if it isn't going to occur with the current firmware
implementations, I do not see the use.  But it will not hurt either.
Simply, I do not care either way...  I leave this up to you ;-)

--
Marco





reply via email to

[Prev in Thread] Current Thread [Next in Thread]