grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] memdisk + grub-mkrescue


From: Pavel Roskin
Subject: Re: [PATCH] memdisk + grub-mkrescue
Date: Mon, 21 Jan 2008 12:47:06 -0500

On Mon, 2008-01-21 at 17:52 +0100, Robert Millan wrote:
> These two were predestined to get together..  attached patch for their
> wedding.
> 
> Comments?

I really like the ability to add more things than just modules
(especially grub.cfg and fonts).  Is that the main motivation for your
patch?  Or you have some other things in mind?

I've tested the patch, and it seems to be OK, although I was surprised
to see an empty menu on startup.  Perhaps a command line would be more
appropriate in absence of grub.cfg?

I don't quite understand why "biosdisk" needs to be mandatory.  I guess
it's not initialized by default, so that it doesn't conflict with the
ata module.  But ata can load on top of biosdisk (but not the other way
around).

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]